Skip to content

Conversation

raul-casallas
Copy link
Contributor

Description

While we review the docs for the SDKs, we decide that, in order to follow the convention of other SDKs the name of the job submission methods, should follow this structure:

jobs.submit_<<type>>

So the official methods are:

  • submit_text
  • submit_file
  • submit_embedded
  • submit_aws_s3
  • submit_jdbc

Other methods were marked with @deprecated in order to discourage his use. Readme files, Tests files, and Sample files were updated to use these methods.

Also, we have used to have double methods (i.e. text for one source, text_bulk for multiple) with this new you can use single or multiple inputs sources, but we encourage the user to use multiple by calling the parameter sources.

Related issues

The update on the docs

Tests

Test are passing, and samples are working.

========================= 10 passed, 1 warning in 36.00s=====================================

Checklist

  • I read the Contributing guide.
  • I update the documentation and if the case the README.md file.
  • I am willing to follow up on review comments in a timely manner.

@bmunday3-zz bmunday3-zz reopened this Aug 16, 2021
@bmunday3-zz bmunday3-zz merged commit 92cf2ef into main Aug 16, 2021
@raul-casallas raul-casallas deleted the feat/docs_review branch September 29, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants