Skip to content

Job history review #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Job history review #4

merged 1 commit into from
Sep 4, 2020

Conversation

raul-casallas
Copy link
Contributor

Description

The SDK has some differences with the job-history-service defined here as follows:

  • jobIdentifiers is no longer supported
  • model wasn't handled by the sdk

Related issues

There are no issues reported

Tests

test_jobs.py was updated according to the new params

Checklist

  • I read the Contributing guide.
  • I update the documentation and if the case the README.md file.
  • I am willing to follow-up on review comments in a timely manner.

@raul-casallas raul-casallas self-assigned this Sep 3, 2020
@nathan-mellis nathan-mellis merged commit 5e9a6bb into main Sep 4, 2020
@nathan-mellis nathan-mellis deleted the job_history_review branch September 4, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants