forked from aws/aws-sam-cli
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cdk support dev merged to develop #3
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Use BUILD_TAG instead of JENKINS_URL to identify Jenkins env * Keep JENKINS_URL
* Updated Deprecated compile to implementation * Updated Tabs to Spaces * Updated for Kotlin * Updated More Tabs to Spaces
* Added Auto Create ECR Design Doc * Updated Format * Addressed feedback
When validating the sam template, SAM CLI requires credentials to get the IAM Manged Policies. SAM Translator also requires the region in order to figure out the parition. Previously, SAM Translator assumed this to be on the Env but SAM CLI could get this information from a command line argument or a profile. This commit passes the boto_session into the SAM Translator lib (v1.35.0 or later), so that SAM Translator can figure out the partition from the information passed to SAM CLI. Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com> Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>
…am local commands (aws#2806)
Co-authored-by: Xia Zhao <xazhao@amazon.com>
…ws#2821) * [Refactor] extract git-clone functionality out of InitTemplates class to its own class * apply review comments * typo * apply review comments
* chore: add command line options to pyinstaller build script * Update quotes * fix the dist folder name * update logs * trigger appveyor build
Co-authored-by: Slava Senchenko <sencslav@amazon.com>
* add github actions to automate our github issue workflow * reformat * update name format * update response message to be more precise * updated with the correct sam bot login name * updated with the correct token name * updated label name and bot name Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>
* Point numpy version to <1.19 to avoid PEP 317 failure * Update integ test python requirements which contain numpy * Fixing to numpy 1.20.2 * Revert "Fixing to numpy 1.20.2" This reverts commit a03f4d7. * Fixing numpy version to <1.20.3
Issue: aws#2355 Added integration tests for `validate` command Co-authored-by: Slava Senchenko <sencslav@amazon.com> Co-authored-by: _sam <3804518+aahung@users.noreply.github.com>
* refactor logs command library * re-organize due to click usage * address comments * adding pylint disable for console consumer * make pylint happy with python 3.6 Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>
…#2864) * Enable --app-template argument for Image package-type while generating a new SAM project using 'sam init' * Fix the exception message * normalize pathes in UT to pass on windows * normalize project-template local path
* feat: Allow dir_checksum() to accept a ignore_list * feat: Ignore .aws-sam when calculate cache md5
… intrinsics) (aws#2879) * fix: Fix crash when nested CFN stack has dict TemplateURL
* get questions' default answers from toml * make black happy * add more docs * rename question's attribute 'default_from_toml' to 'defaultFromToml' and rename 'valueof' to 'key' and add some docs * Add preload_value * Allow to pass toml file to interactive flow run() * Update related classes to utilize proload value context object * Update test * Add missing docstring * Remove samconfig change * Rename extra_context to context because it is required field now * Remove toml logics from this PR * Update comment Co-authored-by: Sam Liu <xinhol@amazon.com> Co-authored-by: _sam <3804518+aahung@users.noreply.github.com>
* chore: updating version of watchdog. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>
* chore: Update aws_lambda_builders to 1.4.0 * Update integration tests for new maven behavior * Add integ test for PEP 600 tags
aws#2883) * Adds missing unit tests for LayerBuildDefinition in build_graph * fix black formatting
* samconfig debug level logging fixed; documentation updated * integration tests fix * help text improved Co-authored-by: Slava Senchenko <sencslav@amazon.com>
* Update --bucket help text * Update --stage help text * Update help text * Update help text * Update help text * Update help text * Update help text * Update jenkins generated files * Update some intro texts * Remove trialing spaces
* Clearing pipeline integ test buckets with versioned objects. * Fixing black formatting. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>
Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>
Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>
* Adding pipeline to pyinstaller. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>
* Including stage resource yaml in pip. * Bumping patch version Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>
* ci: Speed up unit test by caching the git clone
* fix: fixing pipeline init integration test so that it don't break every time we update our template. * black formatting. * cleaning up not needed file. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>
* chore: fix pylint failures in python3.9 * chore: fix pylint failures in python3.9 * chore: bump pylint version to 2.9.0 * fix typo * Add disabling reasons on new rules
… pull limitation (aws#3137)
…rror' (aws#3043) * add sample payload for 'sam local generate-event stepfunctions error' * add better default for error
…pport-dev-merged-to-develop # Conflicts: # appveyor.yml # mypy.ini # samcli/__init__.py # samcli/commands/_utils/template.py # samcli/commands/build/build_context.py # samcli/commands/build/command.py # samcli/commands/deploy/deploy_context.py # samcli/commands/deploy/guided_context.py # samcli/commands/init/__init__.py # samcli/commands/init/init_templates.py # samcli/commands/local/cli_common/invoke_context.py # samcli/commands/local/invoke/cli.py # samcli/commands/local/start_api/cli.py # samcli/commands/local/start_lambda/cli.py # samcli/commands/package/command.py # samcli/lib/package/artifact_exporter.py # samcli/lib/providers/sam_function_provider.py # samcli/lib/providers/sam_stack_provider.py # samcli/lib/utils/git_repo.py # samcli/lib/utils/hash.py # tests/integration/deploy/test_deploy_command.py # tests/testing_utils.py # tests/unit/commands/buildcmd/test_build_context.py # tests/unit/commands/deploy/test_deploy_context.py # tests/unit/commands/deploy/test_guided_context.py # tests/unit/commands/init/test_cli.py # tests/unit/commands/init/test_templates.py # tests/unit/commands/local/cli_common/test_invoke_context.py # tests/unit/commands/local/invoke/test_cli.py # tests/unit/commands/local/lib/test_sam_function_provider.py # tests/unit/commands/local/start_api/test_cli.py # tests/unit/commands/local/start_lambda/test_cli.py # tests/unit/commands/samconfig/test_samconfig.py # tests/unit/lib/build_module/test_build_graph.py # tests/unit/lib/utils/test_git_repo.py # tests/unit/local/lambdafn/test_runtime.py
…k-support-dev-merged-to-develop
aws#3030) * chore: removed unused code which was using pre-defined managed policy list and used in a sam translator wrapper, but the code path is not used. * make black
Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com> Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>
Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>
* Add ECR credentials for windows test * Remove the dockerhub env vars
Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>
* Add ECR credentials for windows test * Remove the dockerhub env vars * install aws cli in the windows test jobs
Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>
…pport-dev-merged-to-develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.