Skip to content

Conversation

horrormyth
Copy link
Contributor

No description provided.

@horrormyth horrormyth changed the title Add requiremnts, ruff pre-commit hook and pytest config Add requirements, ruff pre-commit hook and pytest config Apr 20, 2024
@horrormyth
Copy link
Contributor Author

Will add the guidelines in another PR

@sumanashrestha
Copy link
Collaborator

looks a bit overkill for a project with a single file and 200 LOC tbh.

will this add any additional steps for somebody trying to just run the code ?

@haruBlank00
Copy link

looks a bit overkill for a project with a single file and 200 LOC tbh.

will this add any additional steps for somebody trying to just run the code ?

No it won't add any additional steps to just run the code.
These are formatter and guides for contributors.
It will only effect the developers by making sure everyone share the same config since everyone might have their own config locally

@sumanashrestha sumanashrestha merged commit a07540e into moest-np:main Apr 21, 2024
@horrormyth
Copy link
Contributor Author

Will add the guidelines in another PR

#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants