Changed output file location and added encoding='utf-8' on file write. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done because it was throwing error in windows
sebakthapa
changed the title
|
@sebakthapa It'd be great if we could write the PR and the commit messages answering "When we deploy this commit, then what will happen," i.e., Use the imperative form. Good reference here |
sebakthapa
changed the title
|
would it be better if output path is an option commandline arg instead ? Also see a related desired feature in wishlist #14 |
|
The output file name is already being taken from CLI and I added this folder option to make it managed and so that it can be ignored while committing changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.