-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature: Display Point & RothC output #56
Conversation
Great start! I'm interested to see it with real data. 💯 |
@aornugent I've noticed that |
@waridrox could you please test to check if the configuration is broken or not? Everything seems fine at my end. |
Please have a look at the feature demo in the first comment! |
Great work @shubhamkarande13! A few thoughts:
|
…icts caused by state variables
1a3b67d
to
1af83a9
Compare
@aornugent could you please review the PR once again? I tried to drop the GCBM job commit from this branch. 😅 @waridrox could you please beautify the tables a bit as suggested by @aornugent ? I'm bad at design. 😂 Thank you both! 🤗 |
Here's the preview for modified implementation. The state updation from vuex could be referenced later, though it is a crucial thing to worry about 😕 - https://michaelnthiessen.com/debugging-guide-why-your-component-isnt-updating/ graph-demo.mov |
@waridrox - agreed, it's important. I like the mapState pattern in the link you shared above. I believe this can be used to handle modules that share similar names by setting https://laracasts.com/discuss/channels/vue/vuex-actions-with-same-name-in-different-modules?page=0 But I don't yet understand why we have conflict given that our modules are isolated within components. Is it true that This PR is looking good for now, so let's file an issue to continue the namespace discussion after we merge. |
Description
Displays the received Point and RothC outputs as a grid/spreadsheet.
Introducing RevoGrid for rendering the outputs as a spreadsheet.
Point-RothC-spreadsheet.mp4