Implement GCBM workflow with uploading files / running sim / downloading sim #64
Conversation
shubhamkarande13
requested review from
waridrox,
aornugent,
shloka-gupta and
iamrajiv
|
Here's the preview of the changes - preview.mov |
| @@ -37,6 +37,10 @@ import VueMaterial from 'vue-material' | |||
| // Vue.use(MdList) | |||
| // Vue.use(MdDialog) | |||
| // Vue.use(MdContent) | |||
|
|
|||
| // import VueUploadComponent from 'vue-upload-component' | |||
There was a problem hiding this comment.
Let's delete this if it's not going to be used. Otherwise comments accumulate in the code base and noone remembers why it's there.
| <div class="w-full lg:w-8/12 px-4"> | ||
| </div> | ||
| <div class="w-full lg:w-4/12 px-4"> | ||
| <template> |
There was a problem hiding this comment.
This file looks like it's just a copy of the RothC template? Suggest we remove and tackle GCBM config later, go straight from upload to run.
There was a problem hiding this comment.
Oh it was there just to serve as a filler route, that way we could experiment upon...Sure will update this to the GCBM configs view.
There was a problem hiding this comment.
Gotcha, just leave an empty placeholder then :😉
shubhamkarande13
force-pushed
the
fileUploadGCBM
branch
from
035b6c1
to
63a798f
Compare
|
@shubhamkarande13 if the upload feature is complete, you can merge it and open a new PR to address form data? As a rule of thumb, a PR should only be a few days of work! |
|
|
waridrox
force-pushed
the
fileUploadGCBM
branch
from
ce54f04
to
1256a9c
Compare
|
Here's the preview for the changes - starting.sim.movrunning.sim.to.finished.movdownload.mov |
waridrox
changed the title
|
Thank you so much @mfellows and @aornugent ! This couldn't have been possible without your guidance and support. |
Description
PR to implement uploading of GCBM config and input files to do a GCBM run.
Fixes #6. Also check #61.
Changes:
Add Dropzone as a dependency to implement drag and drop file upload.