-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploading unsupported mime type files from the browser #61
Comments
Hey @waridrox @shubhamkarande13 can you share the entire api call that is being made? The upload requests are made with |
Hi @Tlazypanda, the api calls are yet to be made in the upload-gcbm.mov |
Hey @waridrox I am not sure what change is required on the api end now because if I understand correctly this is on the UI level the file upload component right? If we finally make the api request to multipart/form-data this would be working then ✌️ |
Yes 💯, that would work on the request to multipart/form-data. It's the browser file upload functionality that needs to be tackled first.
… On 20-Aug-2021, at 10:18 PM, Sneha Mishra ***@***.***> wrote:
Hey @waridrox <https://github.com/waridrox> I am not sure what change is required on the api end now because if I understand correctly this is on the UI level the file upload component right? If we finally make the api request to multipart/form-data this would be working then ✌️
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN66V4MRZMW6Y3OKAFEW4A3T52BORANCNFSM5CQPIANA>.
|
Oh that's disappointing! How about we proceed with a zip upload while we work towards a minimum viable product but leave this discussion open for further consideration? This might mean users are not able to edit the config using the UI until we resolve this issue. |
@aornugent Don't worry I have found an alternative component that doesn't restrict uploads on file type or mime type. It looks a bit ugly but can I push the code to this branch till Warid fixes the design when he wakes up (it's 5 AM here)? |
@aornugent @waridrox @Tlazypanda Thank you Sneha for your insights! ✌😄 |
Thanks for everyone's insights, the file upload component that was being used proved to be the limitation instead. Closing this via #64 |
The params for uploading file types in the GCBM runs requires specific file types to be uploaded that are unsupported via the MIME standards in the browser. Some of these are
.db
,.cfg
,.conf
etc. Here's the list for the supported file types in the browser - https://www.iana.org/assignments/media-types/media-types.xhtmlThis is how the file types are getting referenced in the file uploader -
The closest thing that may be possible now is the
.zip
file type which would be sent to the upload route and unzipped there...CC: @aornugent @shubhamkarande13 @HarshCasper
The text was updated successfully, but these errors were encountered: