Shorten Jira error messages #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violine1101
reviewed
Jun 12, 2021
|
I think I've added a LoggerUtil properly, so I'll mark this pull request as ready for review. |
SPGoding
reviewed
Aug 14, 2021
Co-authored-by: SPGoding <15277496+SPGoding@users.noreply.github.com>
violine1101
force-pushed
the
smaller-jira-errors
branch
from
010734b to
4db4a36
Compare
violine1101
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #212.
Approach
This changes the error message in Task.ts, FilterFeedTask.ts, and VersionFeedTask.ts to be only four lines long. These four lines include the status code, status text, and error messages (some of these may not be defined).
These error messages used to be over 300 lines each.
The changes here don't affect other Jira error messages besides these three, but these are the errors that are causing the most spam when the bot can't connect to Jira.
Here is an example of a shortened error message.