Add new method to $dom, $dom->each_text.
#2067
Conversation
|
Please don't combine multiple independent changes into a single PR. It lowers the chances of it being accepted significantly. Keep it to one commit per PR. |
|
Sorry, I think it is the perltidy, let me undo that. |
tcheukueppo
force-pushed
the
main
branch
4 times, most recently
from
95f41da
to
09b7a0a
Compare
|
I specifically meant that adding |
tcheukueppo
changed the title
$dom, $dom->each_text.$dom, $dom->each_text.
|
After performing some tests I think modifying parser regex isn't worth it and thus no PR for that. |
|
done |
| @@ -468,6 +486,16 @@ excluded. | |||
| # "foo\nbarbaz\n" | |||
| $dom->parse("<div>foo\n<p>bar</p>baz\n</div>")->at('div')->all_text; | |||
|
|
|||
| =head2 each_text | |||
|
|
|||
| my @text = $dom->each_text; | |||
There was a problem hiding this comment.
Mojo::Headers's to_hash() can take "1" as an argument, so maybe we could add that to all_text() instead of adding a new method? Also, how about returning a Mojo::Collection?
|
I don't really see the use of this feature i'm afraid. Maybe some more specific examples for use cases would help. |
|
Really sorry for bothering you guys, I was working on a project and I came across this, I thought that do be useful but turns out that my approach was not the right approach, it is obviously not useful to me now and probably be never useful to anyone out there, I found another technique that did not even required me to monkey_patch anything, thanks for your attention, |
|
Closing this PR. |
Hello,
Summary
$dommethod$dom->each_text: which returns text content of every descendant node in a list.$dom->each_text.Motivation
I'd like to have this feature to be table to perform context sensitive parsing on the text content of a given tag(with all it descendant in the most frequent cases) without interference with contents of other
tags(which is something that$dom->all_textdoes not provide), I'm totally aware of$dom->textbut that do require me to walk through the $dom data structure and use css selectors which is quite tedious.