fix: When loading large zip it seems to hang. closes #257 and #302. #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #257. This required better transaction isolation which is achieved by creating a clone of the metadata (Database) and only syncing changes to schema/tables/columns at commit. Alas required many changes.
mswertz
changed the title
mswertz
commented
Jun 24, 2021
| + "\n{firstName:\"Donald\",lastName:\"Mouse\"}" | ||
| + "\n], RefTable:[" | ||
| + "\n{firstName:\"Donald\",lastName:\"Mouse\"}]){message}}"); | ||
| execute( |
There was a problem hiding this comment.
split because graphql doesn't ensure execution order so sometimes fails
sidohaakma
reviewed
Jun 29, 2021
There was a problem hiding this comment.
It looks like adding the schema layer in between which is good I think to decouple the import process from running the application. The feature is working, you can now click around in the application without being delayed by a running import.
However when I leave the upload page I can not track the progress anymore. So if users are clicking on other buttons during the upload, how do I know when it is finished? In the logging I can keep track of it, however the user does not. If the user starts a new large import postgres is running out of memory.
.../molgenis-emx2-io/src/test/java/org/molgenis/emx2/io/TestCohortCatalogueMultipleSchemas.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
sidohaakma
approved these changes
Jul 6, 2021
.../molgenis-emx2-io/src/test/java/org/molgenis/emx2/io/TestCohortCatalogueMultipleSchemas.java
Show resolved
Hide resolved
This was referenced Jul 21, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required better transaction isolation which is achieved by creating a clone of the metadata (Database) and only syncing changes to schema/tables/columns at commit. Alas required many changes.