-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esbuild-bundle-analyzerのGithubActionを導入した #718
Conversation
5d99894
to
aea69d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 43 in 47f42fe
"build": "esbuild app/javascript/*.* --bundle --sourcemap --define:global=window --outdir=app/assets/builds", |
build
スクリプトを esbuild CLI ではなく、API の方を使ったスクリプトに書き換える必要があります- そのスクリプトの中で metafile を書き出す 必要があります
aea69d8
to
855065e
Compare
📦 esbuild Bundle Analysis for sakazukiThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: meta.json, Out file: app/assets/builds/application.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
情報助かる~~~。 |
855065e
to
db70c4c
Compare
お、できたっぽい! |
え、うちのJSが90B!?そんな馬鹿な |
さすがに嘘だわ。手元のビルドだと983.8kbになる |
|
db70c4c
to
f59e764
Compare
それっぽい結果になった。勝ったな! |
chartjsは予想通り大きい。 completionが大量の蔵や銘柄の生データだから重いな。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
おもろそうだし雑approveしま
fix #717
やったこと
やってないこと