Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a top-level folder to distribution archives #99

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

ielis
Copy link
Member

@ielis ielis commented Jun 11, 2024

Put all cohort folders, phenopackets, and the summary file into the top-level directory (root) to prevent flooding the target directory with folders and files.

The name of the root folder is equal to the archive name.

The PR adds a test suite to check the following specifications:

  • the archive includes a summary TSV file
  • the archive includes all phenopackets as JSON files
  • there is just one top-level directory (root)
  • all files and folders are located in the root directory

The specs are tested in the test

Fixes #96

…raction folder with files or cohort subfolders.
@ielis ielis requested a review from pnrobinson June 11, 2024 10:04
@pnrobinson pnrobinson merged commit 12cece3 into main Jul 2, 2024
@pnrobinson pnrobinson deleted the issue-97 branch July 2, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tarballs should unpack into a phenopackets folder
2 participants