feat: Add Banner component #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix plop file for component * Make dropdown story better by including options creation in the story
orrgottlieb
requested changes
Jan 10, 2021
src/components/Banner/Banner.jsx
Outdated
| /** | ||
| * sub title value | ||
| */ | ||
| subtitle: PropTypes.string |
| /** | ||
| * title value | ||
| */ | ||
| title: PropTypes.string, |
| /** | ||
| * image custom style | ||
| */ | ||
| imageClassName: PropTypes.string, |
| /** | ||
| * image alt attribute | ||
| */ | ||
| imageAlt: PropTypes.string, |
There was a problem hiding this comment.
please add a default with a default text
There was a problem hiding this comment.
Already exists =]
src/components/Banner/Banner.scss
Outdated
| } | ||
|
|
||
| &.image-position__left { | ||
| grid-template-areas: |
src/components/Banner/Banner.scss
Outdated
| margin: 0; | ||
| grid-area: title; | ||
| height: 26px; | ||
| font-size: 18px; |
There was a problem hiding this comment.
i would assume that we would use our tyography - not comment to you but for design
https://style.monday.com/?path=/story/foundations-typography--typography
src/components/Banner/Banner.scss
Outdated
| width: content-box; | ||
| max-width: 782px; | ||
| display: -webkit-box; | ||
| -webkit-line-clamp: 3; |
src/components/Banner/Banner.scss
Outdated
| grid-area: image; | ||
| width: 100px; | ||
| height: 100px; | ||
| border-radius: 16px; |
There was a problem hiding this comment.
we have constant for border radius
https://style.monday.com/?path=/story/foundations-global-design--rounded-corners
| @@ -0,0 +1,6 @@ | |||
| export const IMAGE_POSITIONS = Object.freeze({ | |||
There was a problem hiding this comment.
maybe on overkill ? but i'll allow it ❤️
* Add close button support * Add RTL support * Conform to styling standards
orrgottlieb
approved these changes
Jan 10, 2021
talkor
pushed a commit
that referenced
this pull request
Feb 13, 2024
…indicator amitha/feature/icon-text-color-indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Style
Storybook
Tests