This repository was archived by the owner on May 17, 2021. It is now read-only.
fix(import): COMPASS-4164 Preview table values always strings #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Mar 9, 2020
mongodb-js/compass-import-export#120 > - chore: Upgrade to javascript-stringify@2 b5bdc7b Fixes #56 > - fix(import): Preview table values always strings 29148cd Fixes COMPASS-4164 > - fix(import): Hard limit reading fs for preview to first 20kb so preview always shows as fast as possible. 
10 tasks
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Mar 9, 2020
mongodb-js/compass-import-export#120 ## Description (wasn't handling `Date` properly in example @mmarcon had on COMPASS-4164) From mongodb-js/compass-import-export#120 > - chore: Upgrade to javascript-stringify@2 b5bdc7b Fixes #56 > - fix(import): Preview table values always strings 29148cd Fixes COMPASS-4164 > - fix(import): Hard limit reading fs for preview to first 20kb so preview always shows as fast as possible. > >  As a reminder, because we're now using a streaming backend, the total number of documents is likely to be off, especially for very large imports. So, 100% progress but still running is expected behavior. Devtools will log not only the input options that user chose but the estimator details as well:  Summary stats are also logged when the import completes successfully, by user selection or error:  
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.