Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

fix(import): COMPASS-4025: Add tests for number casting #137

Merged
merged 13 commits into from
Mar 19, 2020
Merged

fix(import): COMPASS-4025: Add tests for number casting #137

merged 13 commits into from
Mar 19, 2020

Conversation

imlucas
Copy link
Contributor

@imlucas imlucas commented Mar 16, 2020 •
edited
Loading

TODO

  • make transformProjectedTypes() not disgusting. Update tests to use right transform type shape of arrays not object.!!!!!
  • Add a sourceType to import fields so we can skip casting actual noops like String -> String.
  • Add tests for bson.ObjectId()

@imlucas imlucas merged commit 3b2146d into master Mar 19, 2020
@imlucas imlucas deleted the csv-numbers branch March 19, 2020 16:49
@imlucas imlucas mentioned this pull request Mar 19, 2020
Merged
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@imlucas