INT-582 fix(windows) Evergreen upgrade npm on Windows #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build with installer_filename fix: |
imlucas
added a commit
that referenced
this pull request
Sep 5, 2015
INT-582 fix(windows) Evergreen upgrade npm on Windows
gribnoysup
pushed a commit
that referenced
this pull request
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested here:
https://evergreen.mongodb.com/version/55e7d1683ff122654400006f_0
Windows log says:
OS X log says:
Windows build fails only because installer_filename is still wrong in this branch; fix is in fix-windows.EDIT: I added the fix here and reverted .evergreen.yml changes in fix-windows.I tried using the npm-windows-upgrade module from Microsoft but that requires an administrative shell; we don't have that during our build runs.
npm-windows-upgrade seems to be the optimal approach to incorporate into the builder images.