[Backport 1.9] COMPASS 1747 Fire onCollectionChanged in more cases (#… #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1227) * 🔨 Refactor NamespaceStore test * ✅ Add some basic unit tests * ✅ Add test to detect the 🐛 * 🐛 onCollectionChange should fire on either of DB or Collection changed Example: db1.coll => db2.coll, the collection component is identical, but it is a different collection because it is on a different database. * 🐛 Reuse mongodb-ns It handles the '.' in collection names correctly. * 🎨 Use contexts for test readability * ✅ Add test to detect the second 🐛 * 🐛 Initialize to the default namespace of '' Reproduced on local with: npm test -- --functional https://travis-ci.com/10gen/compass/jobs/88742497 #retry 1) CollectionsStore "before all" hook: Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. https://travis-ci.com/10gen/compass/jobs/89088707
pzrq
force-pushed
the
COMPASS-1897-backport-COMPASS-1747-1.9-releases
branch
from
b21896b to
bbf7c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#1227)
🔨 Refactor NamespaceStore test
✅ Add some basic unit tests
✅ Add test to detect the 🐛
🐛 onCollectionChange should fire on either of DB or Collection changed
Example: db1.coll => db2.coll, the collection component is identical, but it is a different collection because it is on a different database.
It handles the '.' in collection names correctly.
🎨 Use contexts for test readability
✅ Add test to detect the second 🐛
🐛 Initialize to the default namespace of ''
Reproduced on local with:
npm test -- --functional
https://travis-ci.com/10gen/compass/jobs/88742497