-
Notifications
You must be signed in to change notification settings - Fork 234
COMPASS-1217 bump runner and remove .travis.yml hack #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like https://github.com/JedWatson/react-select is actually breaking the selenium webdriver functional tests in the Travis build, specifically that the |
Indexes Tab does not even appear with react-select@1.0.0-rc6: https://github.com/JedWatson/react-select/blob/master/HISTORY.md#v100-rc6--2017-09-10
1a190d0
to
d508f11
Compare
…-renderer When running `npm test -- --enzyme`, fixes the following warnings: Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning. Warning: Shallow renderer has been moved to react-test-renderer/shallow. Update references to remove this warning.
matt-d-rat
approved these changes
Sep 22, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGMT
pzrq
added a commit
that referenced
this pull request
Sep 22, 2017
…1242) * ⬆️ mongodb-runner@3.6.1 * :yay: Remove hack to workaround Travis caches issues * ⬆️ npm@5 * 📌 react-select@1.0.0-rc.5 Indexes Tab does not even appear with react-select@1.0.0-rc6: https://github.com/JedWatson/react-select/blob/master/HISTORY.md#v100-rc6--2017-09-10 * Sanity check npm 5 is installed at least once * ⬆️ chai-enzyme@0.8.0, replace react-addons-test-utils with react-test-renderer When running `npm test -- --enzyme`, fixes the following warnings: Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning. Warning: Shallow renderer has been moved to react-test-renderer/shallow. Update references to remove this warning.
pzrq
added a commit
that referenced
this pull request
Sep 22, 2017
…1242) * ⬆️ mongodb-runner@3.6.1 * :yay: Remove hack to workaround Travis caches issues * ⬆️ npm@5 * 📌 react-select@1.0.0-rc.5 Indexes Tab does not even appear with react-select@1.0.0-rc6: https://github.com/JedWatson/react-select/blob/master/HISTORY.md#v100-rc6--2017-09-10 * Sanity check npm 5 is installed at least once * ⬆️ chai-enzyme@0.8.0, replace react-addons-test-utils with react-test-renderer When running `npm test -- --enzyme`, fixes the following warnings: Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning. Warning: Shallow renderer has been moved to react-test-renderer/shallow. Update references to remove this warning.
This was referenced Sep 22, 2017
pzrq
added a commit
that referenced
this pull request
Sep 22, 2017
…1243) * [Backport 1.9] COMPASS-1217 bump runner and remove .travis.yml hack (#1242) * ⬆️ mongodb-runner@3.6.1 * :yay: Remove hack to workaround Travis caches issues * ⬆️ npm@5 * 📌 react-select@1.0.0-rc.5 Indexes Tab does not even appear with react-select@1.0.0-rc6: https://github.com/JedWatson/react-select/blob/master/HISTORY.md#v100-rc6--2017-09-10 * Sanity check npm 5 is installed at least once * ⬆️ chai-enzyme@0.8.0, replace react-addons-test-utils with react-test-renderer When running `npm test -- --enzyme`, fixes the following warnings: Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning. Warning: Shallow renderer has been moved to react-test-renderer/shallow. Update references to remove this warning. * add libsecret-1-0 to travis config (#1237)
pzrq
added a commit
that referenced
this pull request
Sep 22, 2017
…1244) * [Backport 1.8] COMPASS-1217 bump runner and remove .travis.yml hack (#1242) * ⬆️ mongodb-runner@3.6.1 * :yay: Remove hack to workaround Travis caches issues * ⬆️ npm@5 * 📌 react-select@1.0.0-rc.5 Indexes Tab does not even appear with react-select@1.0.0-rc6: https://github.com/JedWatson/react-select/blob/master/HISTORY.md#v100-rc6--2017-09-10 * Sanity check npm 5 is installed at least once * ⬆️ chai-enzyme@0.8.0, replace react-addons-test-utils with react-test-renderer When running `npm test -- --enzyme`, fixes the following warnings: Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning. Warning: Shallow renderer has been moved to react-test-renderer/shallow. Update references to remove this warning. * Go back to npm@4 * add libsecret-1-0 to travis config (#1237) * 🐛 Resolve incorrectly resolved merge conflict See 67e655e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/10gen/compass-charts/pull/19