Skip to content

Conversation

pzrq
Copy link
Contributor

@pzrq pzrq commented Oct 5, 2017

…tructure (#1255)

  • 🔥 Remove #databases dropDatabase('music') call

It was not created by this test, so if it's needed it would be for earlier test runs? I don't see value in keeping it.

Plus - it might be how the chain of test timeouts gets broken? Let's find out with another test.

  • 🐛 Handle the case where app is undefined

This should be the second failure in at least one of the "main failure chain" pairs, i.e.
https://travis-ci.com/10gen/compass/jobs/92384423

(but not)
https://travis-ci.com/10gen/compass/jobs/92384429

  • 🐛 Handle app null as well as undefined

https://travis-ci.com/10gen/compass/jobs/92556220

  • 🚧 Try container-based infrastructure

Just seeing if it's a cheap win today.
https://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/

  • 🎨 Remove clickDatabaseInSidebar/waitForSidebar calls

They are redundant as they are already done by goToCollection, which is at least a code smell worthwhile removing.

  • noop

  • Revert "noop"

  • noop

  • Revert "noop"

  • noop

  • Revert "noop"

  • noop

  • Revert "noop"

  • noop

  • Revert "noop"

…tructure (#1255)

* 🔥 Remove #databases dropDatabase('music') call

It was not created by this test, so if it's needed it would be for earlier test runs? I don't see value in keeping it.

Plus - it might be how the chain of test timeouts gets broken? Let's find out with another test.

* 🐛 Handle the case where app is undefined

This should be the second failure in at least one of the "main failure chain" pairs, i.e.
https://travis-ci.com/10gen/compass/jobs/92384423

(but not)
https://travis-ci.com/10gen/compass/jobs/92384429

* 🐛 Handle app null as well as undefined

https://travis-ci.com/10gen/compass/jobs/92556220

* 🚧 Try container-based infrastructure

Just seeing if it's a cheap win today.
https://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/

* 🎨 Remove clickDatabaseInSidebar/waitForSidebar calls

They are redundant as they are already done by goToCollection, which is at least a code smell worthwhile removing.

* noop

* Revert "noop"

* noop

* Revert "noop"

* noop

* Revert "noop"

* noop

* Revert "noop"

* noop

* Revert "noop"

#retry
  1) CollectionsStore "before all" hook:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
https://travis-ci.com/10gen/compass/jobs/93287442
@pzrq pzrq force-pushed the COMPASS-2175-backport-COMPASS-2159-1.9-releases branch from 1c290ed to 10609f2 Compare October 5, 2017 04:17
@pzrq pzrq merged commit c2beb66 into 1.9-releases Oct 5, 2017
@pzrq pzrq deleted the COMPASS-2175-backport-COMPASS-2159-1.9-releases branch October 5, 2017 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant