Skip to content

Conversation

pzrq
Copy link
Contributor

@pzrq pzrq commented Oct 5, 2017

See both #1255 and #1165

@pzrq pzrq force-pushed the COMPASS-2176-backport-COMPASS-2159-1.8-releases branch from e029615 to 2b0f5bd Compare October 5, 2017 04:17
…tructure (#1255)

* 🔥 Remove #databases dropDatabase('music') call

It was not created by this test, so if it's needed it would be for earlier test runs? I don't see value in keeping it.

Plus - it might be how the chain of test timeouts gets broken? Let's find out with another test.

* 🐛 Handle the case where app is undefined

This should be the second failure in at least one of the "main failure chain" pairs, i.e.
https://travis-ci.com/10gen/compass/jobs/92384423

(but not)
https://travis-ci.com/10gen/compass/jobs/92384429

* 🐛 Handle app null as well as undefined

https://travis-ci.com/10gen/compass/jobs/92556220

* 🚧 Try container-based infrastructure

Just seeing if it's a cheap win today.
https://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/

* 🎨 Remove clickDatabaseInSidebar/waitForSidebar calls

They are redundant as they are already done by goToCollection, which is at least a code smell worthwhile removing.

* noop

* Revert "noop"

* noop

* Revert "noop"

* noop

* Revert "noop"

* noop

* Revert "noop"

* noop

* Revert "noop"

#retry
  1) #collections when creating & deleting collections when viewing the database when creating a collection when deleting a collection pressing enter on correct collection name removes collection:
     Error: element ("[data-test-id='drop-collection-modal']") still not visible after 8000ms
https://travis-ci.com/10gen/compass/jobs/93287440

  1) #schema when applying a filter in the schema tab "before all" hook:
https://travis-ci.com/10gen/compass/jobs/93288256
@pzrq pzrq force-pushed the COMPASS-2176-backport-COMPASS-2159-1.8-releases branch from 2b0f5bd to 66eb074 Compare October 5, 2017 04:29
…al test race (#1165)

* 🐛 Resolve 'drop-collection-modal functional test race

e.g. https://travis-ci.com/10gen/compass/jobs/83567154

* noop

* Revert "noop"

* noop

* Revert "noop"

* noop

* Revert "noop"

* noop

* Revert "noop"

* noop

* Revert "noop"
@pzrq pzrq force-pushed the COMPASS-2176-backport-COMPASS-2159-1.8-releases branch from 4bf6621 to d700e54 Compare October 5, 2017 04:40
@pzrq pzrq merged commit 0b5b231 into 1.8-releases Oct 5, 2017
@pzrq pzrq deleted the COMPASS-2176-backport-COMPASS-2159-1.8-releases branch October 5, 2017 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant