Skip to content

COMPASS-2164: Restrict 3rd party access to resources #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2017
Merged

COMPASS-2164: Restrict 3rd party access to resources #1263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/app/setup-plugin-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,35 @@ app.pluginManager = new PluginManager(
DISTRIBUTION.plugins
);

/**
* Security related items before moving them to security plugin, phase 1.
*/
const Module = require('module');
const loader = Module._load;

/**
* The require error message.
*/
const ERROR = 'Due to security reasons, 3rd party plugins are not allowed to require ' +
'modules with filesystem, network, or child process access.';

/**
* List of modules that cannot be required.
*/
const ILLEGAL_MODULES = ['fs', 'net', 'tls', 'child_process'];

/**
* Prevent loading of fs, net, tls, and child process for 3rd party plugins.
*/
Module._load = function(request, loc) {
if (ILLEGAL_MODULES.includes(request)) {
if (loc.filename.includes(DEV_PLUGINS)) {
throw new Error(ERROR);
}
}
return loader.apply(this, arguments);
};

app.pluginManager.activate(app.appRegistry);

debug(`Plugin manager activated with distribution ${process.env.HADRON_DISTRIBUTION}.`);