⬆️ electron@0.30.8 #154
Merged
⬆️ electron@0.30.8 #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gribnoysup
pushed a commit
that referenced
this pull request
Apr 26, 2021
* chore: update to `mongodb@3.3.3` * chore: remove extraneous mongodb-core dependency * driver: Update to mongodb@3.3.4 * fix: remove old smoke tests These were breaking on update because of info leakage from driver. 1. Connectivity is tested with `mongodb-connection-model#test()` not via a connect() call because a test should use different timeout values than a connection which will be used more than once. In the case of this test, the selection timeout in the driver is 30000ms which caused this test to fail with `exceeded test timout of 2000`. 2. Retryable reads and writes are now supported by the driver which invalidates the state the disconnect() test relied upon, resulting in a `Topology Destroyed` errror for subsequent calls to the client once closed. Like #1 above, after 30000ms, the `count()` would eventually error but full disconnect() behavior is tested in many other code paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thomas is encountering sporadic segfaults during manual testing, so I thought I'd try upgrading Electron as far as we are currently able. https://github.com/atom/electron/releases
We cannot use v0.33 yet. :(
Patch build:
https://evergreen.mongodb.com/version/561bfd693ff12209010002b1_0