INT-511(Application Menu View like Atom) and INT-664 (Windows Menu) #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where menu items affecting windows would not affect the focused window. An about dialog for non-apple platforms. WIP: finish showShareMenu fn
WaleyChen
changed the title
|
Seems like the big guy @imlucas is out of commission today. |
|
Finally got it to run on Windows. Confirm "Connect" menu item and "About" item to check version. LGTM. Couldn't connect to any server though, but that is probably unrelated. |
WaleyChen
pushed a commit
that referenced
this pull request
Nov 3, 2015
INT-511(Application Menu View like Atom) and INT-664 (Windows Menu)
There was a problem hiding this comment.
FYI - catching up on code reviews. :) This is already merged and LGTM, but this block sure looks odd to my eyes:
Basically: "If X is undefined, make it true".
That's a curious way of saying "I want a default value of true".
ES6 will bring real default values for parameters, but Node doesn't support that feature yet. So looks (as good as possible for today) to me.
gribnoysup
pushed a commit
that referenced
this pull request
Apr 26, 2021
Bumps [electron](https://github.com/electron/electron) from 6.1.7 to 7.1.10. - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v6.1.7...v7.1.10) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@imlucas
This PR is safe to merge in but there are things still left to do to complete the issue/story:
https://jira.mongodb.org/browse/INT-511
Once 1 is accomplished, I can do 2, 3 and 4.
2. Have the Share submenu appear when a schema is shareable and hidden when not.
3. Have the Connect submenu appear when there is no current Connect To window open.
4. Keep track of state for each window.