Skip to content

🐛 transform must be defined before being called #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2015
Merged

🐛 transform must be defined before being called #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions src/minicharts/d3fns/geo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,22 @@ var minicharts_d3fns_geo = function() {
// Draw each marker as a separate SVG element.
overlay.draw = function() {
var layer = d3.select('div.layer');
var transform;

projection = this.getProjection();
var padding = 9;

var transform = function(d) {
var p = new google.maps.LatLng(d[1], d[0]);
p = projection.fromLatLngToDivPixel(p);
d.x = p.x;
d.y = p.y;
var self = d3.select(this);
self
.style('left', p.x - padding + 'px')
.style('top', p.y - padding + 'px');
return self;
};

var marker = layer.selectAll('svg.marker')
.data(data)
.each(transform) // update existing markers
Expand All @@ -268,18 +279,6 @@ var minicharts_d3fns_geo = function() {
.attr('r', 4.5)
.attr('cx', padding)
.attr('cy', padding);

transform = function(d) {
var p = new google.maps.LatLng(d[1], d[0]);
p = projection.fromLatLngToDivPixel(p);
d.x = p.x;
d.y = p.y;
var self = d3.select(this);
self
.style('left', p.x - padding + 'px')
.style('top', p.y - padding + 'px');
return self;
};
}; // end overlay.draw

overlay.setMap(googleMap);
Expand Down