Skip to content

Conversation

imlucas
Copy link
Contributor

@imlucas imlucas commented Dec 6, 2019

Description

Adds a preview table of the file you are importing with checkboxes to exclude fields and select to specify a different type. This closes the current Import Export improvements epic.

Also includes fixes for bug with globalAppRegistry: refresh after import now works and default metrics are back.

Motivation and Context

  • New feature

Screenshot 2019-12-08 21 29 05

@mmarcon I've included extended diagnostics in devtools console you may be able to see in the screenshot. Should help ease any triage/debugging issues in beta.

Open Questions

There are a lot of things I want to tweak and improve already so I started a list in the README.

Dependants

Types of changes

  • Patch (non-breaking change which fixes an issue)

Demo

Using Import to Reshape Apple Health Data Export

Default to CSV:

Screenshot 2019-11-21 00 03 28

Tweak delimiter so it looks right:

Screenshot 2019-11-21 00 03 51

Specified field transforms:

const fields = [
  { path: 'type', checked: false, type: 'String' },
  { path: 'sourceName', checked: true, type: 'String' },
  { path: 'sourceVersion', checked: true, type: 'Number' },
  { path: 'creationDate', checked: true, type: 'Date' },
  { path: 'startDate', checked: true, type: 'Date' },
  { path: 'endDate', checked: true, type: 'Date' }
];

Import done:
Screenshot 2019-11-21 00 15 24

CRUD has my enriched types:

@imlucas imlucas self-assigned this Dec 8, 2019
@imlucas imlucas marked this pull request as ready for review December 9, 2019 02:36
@imlucas imlucas merged commit 0570c6f into master Dec 9, 2019
@imlucas imlucas deleted the import-export/specify-import-types branch December 9, 2019 02:37
@imlucas imlucas requested review from lrlna and mmarcon December 9, 2019 02:37
@lrlna
Copy link
Contributor

lrlna commented Dec 11, 2019

thanks for publishing and merging this in @imlucas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants