COMPASS-4104: urlencode credentials when using X509 #1886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hang on, did we talk about this one going into |
|
@lrlna we need both. We should make it work for 1.20 release (so we will backport it) and we also want to have this fix for future releases, therefore this PR was created. |
|
ah gotcha! sorry for getting confused :O
…On Tue, 21 Jan 2020 at 14:31, Alena Khineika ***@***.***> wrote:
@lrlna <https://github.com/lrlna> we need both. We should make it work
for 1.20 release (so we will backport it) and we also want to have this fix
for future releases, therefore this PR was created.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1886?email_source=notifications&email_token=AB53OCEDXPACKQXN4ND7OOLQ632L3A5CNFSM4KJS7642YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJPXVIA#issuecomment-576682656>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB53OCGYXLAYFOY7OWJVLMTQ632L3ANCNFSM4KJS764Q>
.
|
imlucas
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
compass-connect@5.3.1,mongodb-connection-model@14.4.3andmongodb-data-service@16.1.3that urlencodes credentials when using X509 auth.Motivation and Context
Types of changes