Skip to content

Fixing MQL query validation #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

Fixing MQL query validation #1928

merged 1 commit into from
Mar 24, 2020

Conversation

durran
Copy link
Member

@durran durran commented Mar 24, 2020

Description

Removes client query validation, only verifying the query is a valid JS object. This fixes all those pesky grammar tickets:

Screenshot 2020-03-24 at 20 06 01

Screenshot 2020-03-24 at 20 08 45

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@durran durran merged commit 63b0e61 into master Mar 24, 2020
@durran durran deleted the query-validation branch March 24, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@durran