Skip to content

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Jul 1, 2020

Description

When importing agg pipeline form text limit documents used for a preview even if pipeline includes the out stage, otherwise the aggregation will be executed on the whole collection and freeze the UI. Even tho according to the design the out stage should be the last stage in the pipeline and we expect that all documents should be exported to another collection, we can still use the limit stage here because we don't start exporting yet. To do so a user should click the Save Documents button, and only then the pipeline without limiting will be executed.

For more details see: https://github.com/mongodb-js/compass-aggregations/pull/268
Ticket: https://jira.mongodb.org/browse/COMPASS-4263

I also fixed lint warnings and GitHub templates, since I have noticed these small issues and it was a quick win.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika requested a review from Anemy July 1, 2020 16:32
@Anemy
Copy link
Member

Anemy commented Jul 1, 2020

:shipit:

@alenakhineika alenakhineika merged commit 7740a2b into master Jul 2, 2020
@alenakhineika alenakhineika deleted the COMPASS-4263-use-limit-to-preview-with-out branch July 2, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants