Skip to content

Conversation

mcasimir
Copy link
Collaborator

@mcasimir mcasimir commented Sep 8, 2020

Description

Recreate the icon for Windows so it has also intermediate resolutions. This should prevent the icon to be rendered poorly in the task bar.

Before:

Screenshot 2020-09-08 at 19 46 37

After:

Screenshot 2020-09-08 at 19 46 51

The icon is converted with imagemagik from the png (linux) one:

magick convert mongodb-compass.png -define icon:auto-resize="256,128,96,64,48,32,16" mongodb-compass.ico

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - I wonder how we can test the build on windows to see if it fully fixes it? Should we just merge to master and check the artifacts it creates?
I never knew .ico files have multiple sizes inside xD

@mcasimir
Copy link
Collaborator Author

mcasimir commented Sep 9, 2020

Right how do we see how it looks like? Maybe there is a way to use the icon with npm run start

@mcasimir mcasimir merged commit 5069fa6 into master Sep 9, 2020
@mcasimir mcasimir deleted the recreated-multires-icon branch September 9, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants