Skip to content

Conversation

addaleax
Copy link
Collaborator

@addaleax addaleax commented Sep 30, 2020

🤞

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

package.json Outdated
"enzyme-adapter-react-16": "^1.15.2",
"eslint-config-mongodb-js": "^5.0.3",
"hadron-build": "^23.2.6",
"hadron-build": "^23.3.0",
Copy link
Collaborator

@mcasimir mcasimir Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23.3.1 should stop logging env

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve updated to that – I have no strong feelings about whether we want to drop the write-to-file step then, after sleeping about it it seems more likely to me that somebody would accidentally print environment variables like we did before than accidentally publish files from /tmp/, but obviously either way works just fine for me.

@Anemy
Copy link
Member

Anemy commented Oct 2, 2020

Nice work! Is there a case where we don't want to notarize the bundle? Not really related to this PR, but in https://github.com/mongodb-js/hadron-build/pull/367/files#diff-2265b5363474c70d8268d7c4f5e1e060L545 when the apple credentials aren't set we still continue with the build, I'm wondering if we want to have it error out when the credentials don't exist to make sure we don't release without notarizing.

@addaleax
Copy link
Collaborator Author

addaleax commented Oct 2, 2020

@Rhys To be honest, I don’t know, and I think it might just be that that was the case because we weren’t able to successfully notarize in the past. I don’t see any downsides to doing it always, though, and we also notarize every mongosh build.

@addaleax addaleax merged commit f90010d into master Oct 6, 2020
@addaleax addaleax deleted the 4077-dev branch October 6, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants