INT-780 save ssl cert paths, removing debug msgs #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML file picker cannot set the value programmatically for security reasons. But in electron land we can use their `showOpenDialog`.
rueckstiess
force-pushed
the
INT-780-save-ssl-cert-paths
branch
from
6b41605 to
176941e
Compare
|
HTML5 file pickers cannot set their values programmatically for security reasons (otherwise one could just upload any file, e.g. Electron provides its own file dialogs however. The latest change removes the HTML file pickers and replaces them with custom buttons, that trigger the electron dialog. This allows us to save and restore the ssh paths the user has chosen. Here it is in action:
|
|
|
imlucas
added a commit
that referenced
this pull request
Nov 11, 2015
INT-780 save ssl cert paths, removing debug msgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: ssl cert paths are not restored when clicking on a favorite connection. See INT-780 for explanation.