Skip to content

COMPASS-4503: Use RFC 3986 encoding #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

COMPASS-4503: Use RFC 3986 encoding #2058

merged 1 commit into from
Nov 18, 2020

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Nov 17, 2020 •
edited
Loading

Description

Update to the connection-model@17.0.3 that does RFC 3986 encoding.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika requested a review from Anemy November 17, 2020 14:22
@alenakhineika alenakhineika force-pushed the COMPASS-4503-rfc3986-encoding branch from dca5e22 to 3320246 Compare November 17, 2020 14:49
@rose-m
Copy link
Contributor

rose-m commented Nov 17, 2020

Note: This bump also includes mongodb-js/connection-model#328:

fix: Ensure error thrown on connect is forwarded COMPASS-4473

I forgot to immediately create a new version and then bump it here as I didn't think about the issue with creating the release notes here in COMPASS...

rose-m
rose-m approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@rose-m rose-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with a copied connection string I took from VSCode and it worked 👍 Also creating a new connection and re-connecting, etc. worked.

@alenakhineika alenakhineika merged commit 50ac1de into master Nov 18, 2020
@alenakhineika alenakhineika deleted the COMPASS-4503-rfc3986-encoding branch November 18, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anemy Anemy Awaiting requested review from Anemy

1 more reviewer

@rose-m rose-m rose-m approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alenakhineika @rose-m