Skip to content

fix: installerVersion not aligned with package.json version COMPASS-4545 #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 18, 2020
Merged

fix: installerVersion not aligned with package.json version COMPASS-4545 #2088

merged 6 commits into from
Dec 18, 2020

Conversation

mcasimir
Copy link
Collaborator

Bumps hadron-build to a version that can use the package.json version as version for the MSI installer, and removes the out of sync installerVersion.

Other:

  • Switch the package.json version to a generic placeholder version rather than the arbitrary 1.23.0.
  • Move CI from travis to github actions

@mcasimir mcasimir merged commit 6be7be7 into master Dec 18, 2020
@mcasimir mcasimir deleted the fix-installer-version branch December 18, 2020 12:24
Anemy
Anemy reviewed Dec 18, 2020
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anemy Anemy Anemy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcasimir @Anemy