Skip to content

Conversation

gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented Apr 21, 2021

Opening it in advance so we can start looking into this compass dependencies list to decide what we want (or don't want) to pull into compass monorepo.

Here's the packages that we plan to import list and any feedback will be appreciated!

I tested the migration script with lerna locally and everything seems to work just fine (even most of the lerna bootstrap with some small exceptions). If you want to try it out for yourself I suggest to clone a separate version of compass and use env vars to run the migration script against it.

The base branch is #2152 so that it's easier to rebase when it lands

Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure if we specifically wanted to not include packages that were used across products, but either way the list seems fine to me 👍

Base automatically changed from COMPASS-4701/compass-lerna to master April 21, 2021 16:14
@gribnoysup
Copy link
Collaborator Author

gribnoysup commented Apr 22, 2021

I’m not sure if we specifically wanted to not include packages that were used across products

@addaleax this list is semi-autogenerated based on pulling all compass deps owned by the team and me going through them and checking whether or not compass (or one of the plugins) was the only or main consumer of the lib. The "main" part is definitely highly subjective, so that's why all feedback is so helpful here, thanks!

I think in general we want to pull in as much as possible, but not too much at the same time, which is just tricky, no other way around it. If some libraries are not in the initial import and cause friction for us all the time down the line, we can always revisit and import additional repos here. So if any other lib stands out to you as not belonging here, definitely mark it.

Hope that makes it a bit clearer what our line of thought was here!

@gribnoysup gribnoysup force-pushed the compass-4703-deps-migration-script branch from bb0a095 to 4eb6c00 Compare April 22, 2021 09:40
Copy link
Contributor

@rose-m rose-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That list of repos is huge... I've got a couple that I'd probably also see to be moved there...

FWIW I had just started a list of repos of the mongodb-js org to also get an overview of what repos there are and for which we as a team are responsible for.

@gribnoysup
Copy link
Collaborator Author

Thanks for pointing out all those packages, Michael! Double-checked everything an resolved 👍

Copy link
Collaborator

@mcasimir mcasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🔥

@gribnoysup gribnoysup merged commit d10ddc7 into master Apr 26, 2021
@gribnoysup gribnoysup deleted the compass-4703-deps-migration-script branch April 26, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants