-
Notifications
You must be signed in to change notification settings - Fork 234
feat(monorepo-migration): Add script that imports compass deps into the monorepo #2161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure if we specifically wanted to not include packages that were used across products, but either way the list seems fine to me 👍
@addaleax this list is semi-autogenerated based on pulling all compass deps owned by the team and me going through them and checking whether or not compass (or one of the plugins) was the only or main consumer of the lib. The "main" part is definitely highly subjective, so that's why all feedback is so helpful here, thanks! I think in general we want to pull in as much as possible, but not too much at the same time, which is just tricky, no other way around it. If some libraries are not in the initial import and cause friction for us all the time down the line, we can always revisit and import additional repos here. So if any other lib stands out to you as not belonging here, definitely mark it. Hope that makes it a bit clearer what our line of thought was here! |
bb0a095
to
4eb6c00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That list of repos is huge... I've got a couple that I'd probably also see to be moved there...
FWIW I had just started a list of repos of the mongodb-js
org to also get an overview of what repos there are and for which we as a team are responsible for.
Thanks for pointing out all those packages, Michael! Double-checked everything an resolved 👍 |
…igration-script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🔥
Opening it in advance so we can start looking into this compass dependencies list to decide what we want (or don't want) to pull into compass monorepo.
Here's the packages that we plan to import list and any feedback will be appreciated!
I tested the migration script with lerna locally and everything seems to work just fine (even most of the
lerna bootstrap
with some small exceptions). If you want to try it out for yourself I suggest to clone a separate version of compass and use env vars to run the migration script against it.The base branch is #2152 so that it's easier to rebase when it lands