Skip to content

Conversation

gribnoysup
Copy link
Collaborator

Merging #2173 #2174 caused evergreen to start failing. The gist of the issues causing this was me doing a poor job of cherry-picking commits for #2174 and missing some fixes in the PR, but also a few other things that this PR tries to address:

  • download-akzidenz script that we have in every compass plugin caused a lot of flakiness, so I made the script a bit more fail-proof
  • evergreen ci flow required to save and restore the whole repo between every step on most machines which worked fine while compass was a single package, now when it's a monorepo, this project state persisting just doesn't scale. As there seems to be no better way to preserve project state between tasks, change the config to to every run in one go. Not optimal, but I couldn't find a better way to do it with evergreen. Maybe if we are able to hoist/dedupe all deps and use GitHub Actions for testing, we can only use evergreen only for compass packaging
  • misc fixes: bigger timeouts for some tests, make sure that test scripts in packages are self-contained, eslintignore build artifacts, etc.

Opening it as a draft for now, the pipeline is still red, but I am getting close and having a draft PR makes it easier for me to track progress and applied changes

Seems like nyc package-lock record might be the reason for windows build
failing, let's try to update package-lock and ci again.
…ch-happen so that CI doesn't fail due to connection issues
Seems to be the same issue with nyc on windows as mentioned before
…mongodb-js/compass-server-version, @mongodb-js/compass-shell, @mongodb-js/compass-ssh-tunnel-status, @mongodb-js/compass-status): Update package-lock everywhere where nyc might cause install issues on windows
Otherwise saving/restoring takes too much time because it's done for the
whole monorepo
…dron-auto-update-manager): Make sure that xvfb-maybe with every test command that requires it and not outside of it
This seems to be important for Windows machines
…against unlocked keychain

Otherwise running tests in CI fails with 'User interaction is not allowed.'
…test suite

Creating a new one only for suites that need it seems to cause issues
…r hadron-spectron

Might be the reason Ubuntu tests are stuck
@gribnoysup
Copy link
Collaborator Author

As discussed with @mcasimir this PR more or less managed to address most of the overall monorepo related issues with evergreen CI config, now it's individual tests cases in packages that are failing. To prevent the diff from growing even bigger, we are scoping evergreen tasks back to only run on compass (see 1d08d9e) so that we can unblock release pipeline and merge this, in the meantime I'll compile a list of all failing tests and open separate tasks for them and will continue fixing them one by one.

@gribnoysup gribnoysup marked this pull request as ready for review May 4, 2021 12:37
@gribnoysup
Copy link
Collaborator Author

Green evergreen spawned with latest changes from this PR: https://spruce.mongodb.com/version/6091313a61837d655b403d6a/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked through this together, lgtm
nice work diving into some of these evergreen issues.
Getting our mocha and some other dev deps versions aligned might solve a failing test or two. Looking into that now.
These are our mocha versions lol

{
    '^2.5.3',
    '^3.0.2',
    '^3.1.2',
    '^3.2.0',
    '^4.1.0',
    '^5.0.0',
    '^5.2.0',
    '^6.0.2',
    '^6.1.2',
    '^6.2.2',
    '^7.0.0',
    '^7.0.1',
    '^7.1.0',
    '^7.1.1',
    '^8.0.1',
    '^8.1.3',
    '^8.2.1',
    '^8.3.2'
}

- func: verify

- func: test
# TODO: rhel pretest fails and needs some additional investigation to make it work
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- name: Install Dependencies
run: npm ci
- name: Not Implemented
run: echo "GitHub Actions workflows are disabled for now. To be fixed in https://jira.mongodb.org/browse/COMPASS-4788"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gribnoysup gribnoysup merged commit baabac5 into master May 4, 2021
@gribnoysup gribnoysup deleted the make-sure-evergreen-runs branch May 4, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants