-
Notifications
You must be signed in to change notification settings - Fork 236
fix(ci): Make sure evergreen runs #2177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…that it will fail less
Seems like nyc package-lock record might be the reason for windows build failing, let's try to update package-lock and ci again.
…a-service): Ignore failing depcheck
…ch-happen so that CI doesn't fail due to connection issues
…that hadron-build process doesn't fail
Seems to be the same issue with nyc on windows as mentioned before
…mongodb-js/compass-server-version, @mongodb-js/compass-shell, @mongodb-js/compass-ssh-tunnel-status, @mongodb-js/compass-status): Update package-lock everywhere where nyc might cause install issues on windows
Otherwise saving/restoring takes too much time because it's done for the whole monorepo
…dron-auto-update-manager): Make sure that xvfb-maybe with every test command that requires it and not outside of it
This seems to be important for Windows machines
…ing in a monorepo
…against unlocked keychain Otherwise running tests in CI fails with 'User interaction is not allowed.'
…test suite Creating a new one only for suites that need it seems to cause issues
…rectly on windows
…r hadron-spectron Might be the reason Ubuntu tests are stuck
As discussed with @mcasimir this PR more or less managed to address most of the overall monorepo related issues with evergreen CI config, now it's individual tests cases in packages that are failing. To prevent the diff from growing even bigger, we are scoping evergreen tasks back to only run on compass (see 1d08d9e) so that we can unblock release pipeline and merge this, in the meantime I'll compile a list of all failing tests and open separate tasks for them and will continue fixing them one by one. |
Green evergreen spawned with latest changes from this PR: https://spruce.mongodb.com/version/6091313a61837d655b403d6a/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked through this together, lgtm
nice work diving into some of these evergreen issues.
Getting our mocha and some other dev deps versions aligned might solve a failing test or two. Looking into that now.
These are our mocha versions lol
{
'^2.5.3',
'^3.0.2',
'^3.1.2',
'^3.2.0',
'^4.1.0',
'^5.0.0',
'^5.2.0',
'^6.0.2',
'^6.1.2',
'^6.2.2',
'^7.0.0',
'^7.0.1',
'^7.1.0',
'^7.1.1',
'^8.0.1',
'^8.1.3',
'^8.2.1',
'^8.3.2'
}
- func: verify | ||
|
||
- func: test | ||
# TODO: rhel pretest fails and needs some additional investigation to make it work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a ticket for that https://jira.mongodb.org/browse/COMPASS-4789
- name: Install Dependencies | ||
run: npm ci | ||
- name: Not Implemented | ||
run: echo "GitHub Actions workflows are disabled for now. To be fixed in https://jira.mongodb.org/browse/COMPASS-4788" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #2174 (comment). Opened a ticket for that https://jira.mongodb.org/browse/COMPASS-4788
Merging #2173 #2174 caused evergreen to start failing. The gist of the issues causing this was me doing a poor job of cherry-picking commits for #2174 and missing some fixes in the PR, but also a few other things that this PR tries to address:
download-akzidenz
script that we have in every compass plugin caused a lot of flakiness, so I made the script a bit more fail-proofsave
andrestore
the whole repo between every step on most machines which worked fine while compass was a single package, now when it's a monorepo, this project state persisting just doesn't scale. As there seems to be no better way to preserve project state between tasks, change the config to to every run in one go. Not optimal, but I couldn't find a better way to do it with evergreen. Maybe if we are able to hoist/dedupe all deps and use GitHub Actions for testing, we can only use evergreen only for compass packagingOpening it as a draft for now, the pipeline is still red, but I am getting close and having a draft PR makes it easier for me to track progress and applied changes