Skip to content

Conversation

mcasimir
Copy link
Collaborator

@mcasimir mcasimir commented May 17, 2021

  • Allow to create timeseries collections from the create collection dialog if server >= v5.0
  • Add leafygreen to the create collection dialog
  • Add properties badges for collation, view, timeseries, read-only and capped to the collections table
  • Fix https://jira.mongodb.org/browse/COMPASS-3921

< 5

time-series-v4.mp4

>= 5

ts-with50.mp4

Create modal

createmodal.mp4

Notes / Known issues (already present in master):

  • capped is always false when a collection is loaded
  • creating and deleting a collection brings you back to the wrong screen (database list)
  • creating a collection with collation fails in development with a seemingly unrelated error that suggests that the wrong command is invoked, could be a webpack issue.

Screenshot 2021-05-19 at 21 37 56

@mcasimir mcasimir changed the title WIP: feat(collections-ddl): add time-series support COMPASS-4778 feat(collections-ddl): add time-series support COMPASS-4778 May 19, 2021
return (
<div className={styles['create-collection-modal-is-time-series-wrapper']}>
<TimeSeries changeTimeSeriesOption={this.props.changeTimeSeriesOption}
timeSeries={this.props.collation}/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be timeSeries={this.props.timeseries}?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah .. nice catch, wondering how this causes no issue 😕

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait a minute .. that prop is useless i think, unless we would ever do an "edit" dialog, cause leafygreen fields don't need the prop value to change content while you type. i can probably just ditch it entirely.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i've removed it, let me know if you see issues with that.

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice job starting to pull some leafygreen into compass! Nice improvements to the dev env of this package.
Tried out making time series collections and works nice and smooth. Was also able to get that collation error on dev but not when packaging it pulling it into Compass. :/

I love seeing less of the unnecessary classnames and fewer webpack aliases :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants