-
Notifications
You must be signed in to change notification settings - Fork 235
feat(collections-ddl): add time-series support COMPASS-4778 #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
return ( | ||
<div className={styles['create-collection-modal-is-time-series-wrapper']}> | ||
<TimeSeries changeTimeSeriesOption={this.props.changeTimeSeriesOption} | ||
timeSeries={this.props.collation}/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be timeSeries={this.props.timeseries}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah .. nice catch, wondering how this causes no issue 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait a minute .. that prop is useless i think, unless we would ever do an "edit" dialog, cause leafygreen fields don't need the prop value to change content while you type. i can probably just ditch it entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i've removed it, let me know if you see issues with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - nice job starting to pull some leafygreen into compass! Nice improvements to the dev env of this package.
Tried out making time series collections and works nice and smooth. Was also able to get that collation error on dev but not when packaging it pulling it into Compass. :/
I love seeing less of the unnecessary classnames
and fewer webpack aliases :)
< 5
time-series-v4.mp4
>= 5
ts-with50.mp4
Create modal
createmodal.mp4
Notes / Known issues (already present in master):
capped
is alwaysfalse
when a collection is loaded