fix(mongodb-compass): Only unpack required files from mongodb-client-encryption to avoid "Path too long" errors on Windows #2217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of windows build breaking on master seems to be in that one of the files in the unpacked dependencies of
node-runtime-worker-thread(specifically inmongodb-client-encryption) is exceeding the Windows path length limitation. Fortunately all those files should not be part of the package distribution. As a workaround for now while we are waiting for the root cause to resolve we will me a bit more explicit about what's unpacked from asar bundle.Evergreen run that should hopefully be ✅ now: https://spruce.mongodb.com/task/10gen_compass_master_windows_oneshot_compile_test_package_publish_patch_db035af17b9f91a09a0d3cda0d621714c3a50470_60b51bed850e61283ce5e802_21_05_31_17_25_10