Skip to content

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Jun 8, 2021

COMPASS-4846

This PR adds an icon for time-series collections in the sidebar. It also updates the view icon to use leafygreen. Here are the leafygreen icons: https://github.com/mongodb/leafygreen-ui/tree/main/packages/icon

If all is good, before merging just need to double check with Claudia.
This is also a place that down the line we probably want a generic Icon component that wraps leafygreen in a package in Compass.

Here's how they look:
Screen Shot 2021-06-08 at 3 26 22 PM

@Anemy Anemy changed the title Add icon for time series, update view icon feat(compass-sidebar): add icon for time series, update view icon COMPASS-4846 Jun 8, 2021
Copy link
Contributor

@rose-m rose-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Anemy
Copy link
Member Author

Anemy commented Jun 9, 2021

@rose-m synced w/ Claudia and updated styles.
Screen Shot 2021-06-09 at 8 58 47 AM
Will merge once all green.

@Anemy Anemy merged commit d09ac26 into master Jun 9, 2021
@Anemy Anemy deleted the COMPASS-4846 branch June 9, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants