feat(@mongodb-js/compass-home, mongodb-compass): Replaces compass-*-ddl plugins, with compass-databases-collections COMPASS-4830 #2240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tabases,collections}-ddl plugins, with compass-databases-collections Co-Authored-By: Anemy <rhysh@live.com>
…ingified value in Select box so that it can be selected in UI
…ds to the root level of collection fields While at it, refactor form values to options transformation so that `buildOptions` are the only place where field values are normalized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
*-ddlplugins in Compass app and in dev mode ofcompass-homeplugin with the newdatabases-collectionsplugin. While applying the change we spotted a few small bugs that are also addressed in this PR:expireAfterSecondsis a timeseries option, but it's supposed to be on the root level of the options, not scoped totimeseries"false"were not applied in the form due to being falsy and the value prop check falling back to""