feat(explain-plan): Explain on time-series collection COMPASS-4840 #2243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
changed the title
Anemy
changed the title
gribnoysup
approved these changes
Jun 15, 2021
Anemy
force-pushed
the
COMPASS-4840
branch
2 times, most recently
from
46c3a66 to
790b84d
Compare
|
Updated type with more generalized error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-4840
This PR adds a check when parsing explain output that sees if the output resembles an aggregation pipeline. In those cases it then skips further parsing and applies a flag which the ui then uses to display a banner saying we don't support visualizing explains on time series collections yet. It also adds a try catch around parsing explain plans, so that we can more gracefully handle errors, and still show the explain plan output in those cases.
Created this ticket for eventually handling explains of aggregation pipelines/time-series collections: COMPASS-4886
Explain on time series collection then normal collection:
explain-on-time-series.mp4
The message:
Running the type by Claudia & Max currently