Skip to content

feat(compass-sidebar): Add folder icon to collections in sidebar #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2021
Merged

feat(compass-sidebar): Add folder icon to collections in sidebar #2248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/compass-sidebar/src/components/sidebar-collection/sidebar-collection.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { collectionMetadata, getSource } from '../../modules/collection';

import styles from './sidebar-collection.less';

const DEFAULT_COLLECTION_TYPE = 'collection';
const TIME_SERIES_COLLECTION_TYPE = 'timeseries';

class SidebarCollection extends PureComponent {
Expand Down Expand Up @@ -137,6 +138,16 @@ class SidebarCollection extends PureComponent {
}
}

renderCollectionIcon() {
return (
<Icon
className={styles['compass-sidebar-collection-type-icon']}
glyph="Folder"
title="Collection"
/>
);
}

/**
* Render the readonly icon.
*
Expand Down Expand Up @@ -230,6 +241,7 @@ class SidebarCollection extends PureComponent {
data-test-id="sidebar-collection"
title={this.props._id}
>
{this.props.type === DEFAULT_COLLECTION_TYPE && this.renderCollectionIcon()}
{this.props.readonly && this.renderViewIcon()}
{this.props.type === TIME_SERIES_COLLECTION_TYPE && this.renderTimeSeriesIcon()}
{collectionName}
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-sidebar/src/components/sidebar-collection/sidebar-collection.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ describe('SidebarCollection [Component]', () => {
description="description"
activeNamespace=""
globalAppRegistryEmit={emitSpy}
type="collection"
/>);
});

Expand All @@ -44,8 +45,8 @@ describe('SidebarCollection [Component]', () => {
expect(component.find('[data-test-id="sidebar-collection"]').text()).to.match(/coll/);
});

it('does not have a collection type icon', () => {
expect(component.find(Icon)).to.be.not.present();
it('has a collection type icon', () => {
expect(component.find(Icon).props().glyph).to.equal('Folder');
});
});

Expand Down