fix(connection-model): make mongodb a proper dependency #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package depends on the mongodb driver not just as a dev requirement, but also for its actual code. I’ve spent some time trying to make it compatible so that it would work with the 4.0 driver as well, but that seems like a larger task after all and it probably makes more sense to just do proper npm dependency declaration here, and make sure that this package always gets the 3.x driver.
mcasimir
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package depends on the mongodb driver not just as a dev
requirement, but also for its actual code.
I’ve spent some time trying to make it compatible so that it
would work with the 4.0 driver as well, but that seems like a
larger task after all and it probably makes more sense to just
do proper npm dependency declaration here, and make sure that
this package always gets the 3.x driver.