feat: bump driver to 4.x beta COMPASS-4805

[addaleax]

This is fairly functional already, but e.g. the aggregation pipeline builder doesn't appear to work yet, and I have only checked a small subset of Compass's functionality here.

Description

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Dependents

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[mcasimir]

the aggregation pipeline builder doesn't appear to work yet

What does it mean? :)

[addaleax]

the aggregation pipeline builder doesn't appear to work yet

What does it mean? :)

@mcasimir It means that the error from the driver could be undefined instead of null for aggregation .toArray(), but that's fixed now (in bbd05d0) :)

[mcasimir]

Could we 'copy-paste' the parse-connection-string.js file and drop this one? We need to rework that to switch it to the new module anyway.

[addaleax]

I think we could... but I don't think we'd exactly want that to be the long-term solution here either, it's probably best to do some actual URL parsing based on mongodb-connection-string-url and then actually handle all the transformations here in the connection model directly (assuming that we keep mongodb-connection-model)

[mcasimir]

but I don't think we'd exactly want that to be the long-term solution here either

Yeah i was thinking the same, we should definitely use the mongodb-connection-string-url module instead.

[mcasimir]

Nice :)

[mcasimir]

the aggregation pipeline builder doesn't appear to work yet

What does it mean? :)

@mcasimir It means that the error from the driver could be undefined instead of null for aggregation .toArray(), but that's fixed now (in bbd05d0) :)

Oh ok :)

[mcasimir]

Great! Should we merge now and get this in the next release? Or we prefer to wait?

[addaleax]

Great! Should we merge now and get this in the next release? Or we prefer to wait?

As you prefer :) In any case, we should do at least one beta with this I would say. And I don't know if we want to actually do a compass GA release with a beta of the driver instead of a rc.0?

[mcasimir]

Great! Should we merge now and get this in the next release? Or we prefer to wait?

As you prefer :) In any case, we should do at least one beta with this I would say. And I don't know if we want to actually do a compass GA release with a beta of the driver instead of a rc.0?

There should be no issue with that. What does @mmarcon says?

[mmarcon]

We are going to GA the shell with a beta of the driver, I think it's fine to ship Compass too.

But yeah, let's definitely do a beta of compass with that before we do a GA.