fix(compass-crud, data-service): Use new driver update document options #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent update option
addaleax
approved these changes
Jun 18, 2021
|
Merged latest changes into the branch to see how CI will run now |
mcasimir
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver v4 compatibility fix. We were receiving this error:
An error occured when attempting to update the document: findOneAndUpdate option returnOriginal is deprecated in favor of returnDocument and cannot be combinedSince we were supplying both the old and new options. This PR updates the
data-serviceandcompass-crudto use the new driver syntax exclusively. This does mean we'll have to use the new driver option syntax in vscode if we're updating thedata-servicethere as well.