ci(github): Include private packages when doing a canary publish in ci #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise packages/compass doesn't get the version update
gribnoysup
force-pushed
the
third-time-is-the-charm
branch
from
39e3a4e to
b489dd5
Compare
|
Anticipating this to fail because seems like we now have direct dependency on |
…spend time on this in ci
gribnoysup
commented
Jun 20, 2021
| ] | ||
| }, | ||
| "rebuild": { | ||
| "onlyModules": ["interruptor", "keytar", "kerberos"] |
There was a problem hiding this comment.
I guess eventually we want mongodb-client-encryption to be a part of this list so it can be used in Compass shell, but for now this doesn't change any current behavior
mcasimir
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another thing that I missed while making builds work in GitHub CI: because we are doing a canary release that doesn't commit anything, the
versionlifecycle is not running and compass doesn't get a dependencies version bump while doing a release. With this change we should finally get a Compass build in CI that is happening against local modules