feat(compass-crud): Show document actions for time series collections COMPASS-4781 #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
commented
Jun 22, 2021
| this.props.activeIsReadonly, | ||
| this.props.activeSourceName | ||
| ); | ||
| this.props.createNewTab({ |
There was a problem hiding this comment.
Ah we need to send it here too - looks like this might also be a small bug with not supplying the sourcePipeline as well
gribnoysup
approved these changes
Jun 23, 2021
| ); | ||
| this.props.selectOrCreateTab({ | ||
| namespace: this.props.editViewName, | ||
| isReadonly: true, |
There was a problem hiding this comment.
Definitely easier to see what's up at a glance now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-4781
This PR updates how we show documents in time-series collections to only show cloning and copying documents (time-series collections can only be added to, not edited).
Since we were customizing the actions for certain collections, I also noticed we could add copying documents in a few places. This pr adds the ability to copy an explain plan and copy a document in a view.
A bit of refactoring on how tabs pass their collection information around, less argument list and more objects - is this a useful refactor?
Maybe we wait till post 1.27 to merge since it hits a few packages.
These changes also fix a couple smaller bugs when user would create new tabs from a read only view, they would be shown editing functionality.
document in time-series collection
document in view w/ copy button
explain w/ copy button
