fix(import-export): Use query document count in export COMPASS-4537, COMPASS-4906 #2307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect count, fix showing undefined for filter
Anemy
commented
Jun 29, 2021
| export default function(ns, spec) { | ||
| let ret = `db.${toNS(ns).collection}.find(\n`; | ||
| ret += ' ' + stringify(spec.filter, ''); | ||
| ret += ' ' + stringify(spec.filter ? spec.filter : {}, ''); |
mcasimir
reviewed
Jun 30, 2021
| { | ||
| ...(query.limit ? { limit: query.limit } : {} ), | ||
| ...(query.skip ? { skip: query.skip } : {} ) | ||
| } |
There was a problem hiding this comment.
We probably need to handle a failure + add a maxTimeMs here? Something like return undefined and if the count is undefined we hide the number and the progress bar?
mcasimir
reviewed
Jun 30, 2021
| && !query.skip | ||
| ) { | ||
| try { | ||
| const runEstimatedDocumentCount = promisify(dataService.estimatedCount.bind(dataService)); |
There was a problem hiding this comment.
Nice idea! Maybe we could add a debug call for when it fails.
mcasimir
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-4537 COMPASS-4906
This PR fixes a couple bugs around import/export:
estimatedDocumentCounterrors on views and time-series collections, so now we usecountDocuments. This is more expensive, so we could change up the ui here to either background load with a loader, or hide the count entirely. We do get to skip the count when we open the export from the export button oncompass-crudby passing the count from the resulting query there.undefinedfor an empty query (screenshot in comment).open-exportandopen-importapp registry messages/events. Previously we had both of these modals sharing the same store and subscribing to the same messages/events. Didn't really cause any issues before, but now that we're supplying the correct count we probably don't want to be duplicating a possibly expensivecountDocumentscall.