Skip to content

Conversation

mcasimir
Copy link
Collaborator

@mcasimir mcasimir commented Jul 8, 2021

No description provided.

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can leave a comment like

// Because we're storing the connections twice and performing async operations
// on the connections with synchronous assumptions, sometimes these two connection
// stores get out of sync and we can fail to find the connection to delete.

lol looks good though

@mcasimir
Copy link
Collaborator Author

mcasimir commented Jul 9, 2021

Maybe we can leave a comment like

// Because we're storing the connections twice and performing async operations
// on the connections with synchronous assumptions, sometimes these two connection
// stores get out of sync and we can fail to find the connection to delete.

lol looks good though

Thanks! Copy pasting this!

@mcasimir mcasimir merged commit 1b61728 into main Jul 19, 2021
@mcasimir mcasimir deleted the safe-save-recent branch July 19, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants