Skip to content

Conversation

kangas
Copy link
Contributor

@kangas kangas commented May 22, 2015

@imlucas Here is a gulp task that appears to sign Scout.app on my box.
Usage:

XCODE_SIGNING_IDENTITY="90E39AA7832E95369F0FC6DAF823A04DFBD9CF7A" gulp sign

By default it assumes the keychain you need is already unlocked, e.g. your "login" keychain, and the relevant signing certificate is loaded into that keychain.

I'm happy to rewrite the script gunk as native gulp code later. Ideally Xcode just gets fixed so "codesign --deep" works in one step.

@kangas kangas force-pushed the kangas-sign-electron branch from f7bf1d3 to d6f8016 Compare May 22, 2015 21:31
@kangas kangas force-pushed the kangas-sign-electron branch from d6f8016 to 7272893 Compare May 22, 2015 21:39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script.stdout.pipe(process.stdout);
script.stderr.pipe(process.stderr);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to see output progressively. AFAIK .pipe buffers output, but worth
testing!
On May 25, 2015 11:45 AM, "Lucas Hrabovsky" notifications@github.com
wrote:

In scout-electron/gulpfile.js
#24 (comment):

  •  if (err) return done(err);
    
  •  signApp(done);
    
  • });
    +function signAppDarwin(done) {
  • if (process.env.XCODE_SIGNING_IDENTITY) {
  • // var cmd = util.format('codesign --deep --force --verbose --sign %s %s',
  • // process.env.XCODE_SIGNING_IDENTITY, APP);
  • // Use a shell script until we rewrite it in gulp
  • var logData = function(data) {
  •  console.log((''+ data).trim());
    
  • };
  • var script = proc.spawn("./darwin-sign-app.sh",
  •                        [process.env.XCODE_SIGNING_IDENTITY, APP]);
    
  • script.stdout.on('data', logData);

script.stdout.pipe(process.stdout);
script.stderr.pipe(process.stderr);


Reply to this email directly or view it on GitHub
https://github.com/10gen/scout/pull/24/files#r30985631.

imlucas added a commit that referenced this pull request May 26, 2015
fix(electron): delegate 'sign' to darwin-sign-app.sh
@imlucas imlucas merged commit fd26e63 into dev May 26, 2015
@kangas kangas deleted the kangas-sign-electron branch May 29, 2015 18:41
gribnoysup pushed a commit that referenced this pull request Apr 26, 2021
INT-1010 fix test for is user logged in
gribnoysup pushed a commit that referenced this pull request Apr 26, 2021
Bumps [mongodb-js-precommit](https://github.com/mongodb-js/precommit) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/mongodb-js/precommit/releases)
- [Commits](mongodb-js/precommit@v2.2.0...v2.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants